Page 13 of 118

Re: Testing MrMC 3.7.0

Posted: 09 May 2018, 09:48
by pecinko
amet wrote: 09 May 2018, 08:32 we have "Library.HasContent(Movies)" or tvshows or music, so hiding the button is controlled by the core.. what am I missing?

EDIT: granted, Library.HasContent(xxxxx) needs to be extended a bit to allow for Plex and emby services... I will work on that..
If everything is there why does Opacity offer user selectable flip-flops in skin settings instead of taking care of Home automatically? :-)

Re: Testing MrMC 3.7.0

Posted: 09 May 2018, 10:04
by amet
pecinko wrote: 09 May 2018, 09:48
amet wrote: 09 May 2018, 08:32 we have "Library.HasContent(Movies)" or tvshows or music, so hiding the button is controlled by the core.. what am I missing?

EDIT: granted, Library.HasContent(xxxxx) needs to be extended a bit to allow for Plex and emby services... I will work on that..
If everything is there why does Opacity offer user selectable flip-flops in skin settings instead of taking care of Home automatically? :-)
cos some people (ie me) like to hide some items manually regardless ... items are hidden until you setup library and you can hide them again using the "flip-flop"

https://github.com/MrMC/skin.opacity/bl ... e.xml#L181

Re: Testing MrMC 3.7.0

Posted: 09 May 2018, 10:42
by pecinko
amet wrote: 09 May 2018, 10:04 cos some people (ie me) like to hide some items manually regardless ... items are hidden until you setup library and you can hide them again using the "flip-flop"

https://github.com/MrMC/skin.opacity/bl ... e.xml#L181
Interesting :-) I have chosen a bit different approach - I add only things I want to see. It kinda eliminates 2 unnecessary steps - need to add and need to hide stuff.

What's that github link about?

Re: Testing MrMC 3.7.0

Posted: 09 May 2018, 12:34
by ameibein
amet wrote: 05 May 2018, 11:23 anyone tested new skin? Ariana.. thanks to @pecinko
I get a black bar at the top when scanning with this skin but the text is black so hard to read, should be white?

ATV4

Re: Testing MrMC 3.7.0

Posted: 09 May 2018, 13:53
by amet
pecinko wrote: 09 May 2018, 10:42 .... What's that github link about?
Shows the usage of “Library.HasContent(xxxx)”

Re: Testing MrMC 3.7.0

Posted: 09 May 2018, 14:43
by pecinko
amet wrote: 09 May 2018, 13:53 Shows the usage of “Library.HasContent(xxxx)”
Does it look like I need it? :-)

In your example TV Shows home menu item will still appear unless manually flopped off :-) in case user does NOT have shows in library but uses PMS. Comments you see here are about PMS users seeing Home items for the media they don't have/use on PMS. Music is the same case.

Re: Testing MrMC 3.7.0

Posted: 09 May 2018, 17:48
by amet
pecinko wrote: 09 May 2018, 14:43
Does it look like I need it? :-)
not sure, you wanted it to be done automatically by core... :)
pecinko wrote: 09 May 2018, 14:43 In your example TV Shows home menu item will still appear unless manually flopped off :-) in case user does NOT have shows in library but uses PMS. Comments you see here are about PMS users seeing Home items for the media they don't have/use on PMS. Music is the same case.
it doesnt mean that

Code: Select all

<visible>!Skin.HasSetting(HomeMenuNoTVShowButton) + [Library.HasServices | Library.HasContent(TVShows)]</visible>
item will be visible if "HomeMenuNoTVShowButton" is not set(meaning "Yes" show me the button) and if "Library.HasServices" is set to true or Library.HasContent(TVShows) is set to true

in 3.6.2
Library.HasContent(TVShows) is set to true if Mysql or sqlite has tvshow library
Library.HasServices is set to true if either Plex or Emby is enabled

so, in above example , if user didnt touch the radio button to hide TvShows in home, either plex/emby is enabled or MySql/sqlite library has TvShows the button will be visible

in 3.7.0(next testfligtht)
Library.HasContent(TVShows) is set to true if Mysql or sqlite has tvshow library or if plex or emby has tvshows section.... as promised here -> viewtopic.php?f=10&p=17606#p17601
Library.HasServices becomes redundant , it will always return false for backward compatibility

so, in above example , if user didnt touch the radio button to hide TvShows in home, either plex/emby is enabled and has tvshow section or MySql/sqlite library has TvShows the button will be visible

hope its clearer now :)

Re: Testing MrMC 3.7.0

Posted: 09 May 2018, 22:05
by Montoya
@Pecinko, Nice work on your skin, so thank you !

I'm missing the TV button on Home Screen for the installed PVR in MrMC. Is that work in progress ?

Re: Testing MrMC 3.7.0

Posted: 10 May 2018, 06:57
by pecinko
Montoya wrote: 09 May 2018, 22:05 @Pecinko, Nice work on your skin, so thank you !

I'm missing the TV button on Home Screen for the installed PVR in MrMC. Is that work in progress ?
Thanks.

PVR? Maybe.. I don't have a working setup to test on and I'm not sure about needed effort to skin so many PVR windows.

Re: Testing MrMC 3.7.0

Posted: 10 May 2018, 07:20
by guibaa
pecinko wrote: 10 May 2018, 06:57
Thanks.

PVR? Maybe.. I don't have a working setup to test on and I'm not sure about needed effort to skin so many PVR windows.

This is an important feature for me as I control the entire media landscape through MrMC. So also the TV control. It would be nice if this is still implemented.

What I noticed is the startup screen, when I scroll down to Music I don't see any cover images.

Thanks
guibaa