Yatse support

[amet]

So I've added support for MrMC and did more verification.

MrMC JSON level is Jarvis. There's 0 Krypton JSON API changes included.

If DB is at V17 level, then there's quite a few JSON things that would be cool to have for music and the userratings.

are JSON changes breaking Jarvis functionality or are they just additional JSON calls? if its additional stuff we can add that in ...

[Tolriq]

There's breaking and non breaking changes

Don't know the level of the DB have not looked that far for now.
Does your DB includes Music roles and latest Dave changes?

Non breaking changes and easy:
- https://github.com/xbmc/xbmc/pull/9256
- https://github.com/xbmc/xbmc/pull/9749
- https://github.com/xbmc/xbmc/pull/10008
- https://github.com/xbmc/xbmc/pull/9333
- https://github.com/xbmc/xbmc/pull/9246

- https://github.com/xbmc/xbmc/pull/8871
- https://github.com/xbmc/xbmc/pull/8862
- https://github.com/xbmc/xbmc/pull/8872
- https://github.com/xbmc/xbmc/pull/10561
- https://github.com/xbmc/xbmc/pull/9809
- https://github.com/xbmc/xbmc/pull/8880

- https://github.com/xbmc/xbmc/pull/13059 (This one is V18 but nice fix and easy to backport)

Then there's some music breaking and non breaking changes but all interconnected and spread over multiple PRs from Dave

[Tolriq]

If anyone is interested last Yatse beta 8.3.0B2 does include support for MrMc (https://play.google.com/store/apps/deta ... widgetfree)

Streaming seems to work for local media even if it should maybe not, and not yet tested with MrMC internal Plex / Emby support.
But all the rest should work

[Tolriq]

@Davilla have you seen:

Started to play and it seems Zebra is half working on Android? I can access the sources content without any problems.

Via urls: http://192.168.1.40:8080/vfs/nfs%3A%2F% ... 2Ftoto.mkv

Can only guess https://github.com/MrMC/mrmc/blob/maste ... s.cpp#L257 returns null on Android?

Might worth a check, I love that it does work for my need, but maybe on Android there's still some directory traversal security issues then.

Just so I know what to put in the Changelog (Either full support or not) if the fact that it works is a bug that will be fixed.

[amet]

I suspect we need .. but @koying and @davilla might have more to add

Code: Select all

  char *fullpath = realpath(filePath.c_str(), nullptr);
  if (fullpath)
  {
  	....
  }
  else
  {
    return false;
  }

  return true;

[amet]

...
Just so I know what to put in the Changelog (Either full support or not) if the fact that it works is a bug that will be fixed.

I think we need to patch that hole, we should not allow any files to be served via webui that are not in userfolder

[Tolriq]

Well no if you do that and it's really null on Android then you lock access to things that should be allowed by Zebra and will probably break things

Fix should probably to have a non null value

But then the first discussion cames back and I'll ask for support of:
https://github.com/xbmc/xbmc/pull/2764
and
https://github.com/xbmc/xbmc/pull/2828

Or maybe I miss read the Zebra thing but can't test on apple things to confirm

Edit: Please see PR and discussion since start here It was complicated to reach an agreement on Kodi side but I'm sure we can do the same here. Access to sources via a flag that users can configure should be possible.

[amet]

Well no if you do that and it's really null on Android then you lock access to things that should be allowed by Zebra and will probably break things

Fix should probably to have a non null value

...

if fullpath is null, end of story... we cant allow it blindly

if fullpath comes back as something usable, then we check if its "special://home" and allow, or if its not we send false.

[amet]

...

But then the first discussion cames back and I'll ask for support of:
https://github.com/xbmc/xbmc/pull/2764
and
https://github.com/xbmc/xbmc/pull/2828

Or maybe I miss read the Zebra thing but can't test on apple things to confirm

Edit: Please see PR and discussion since start here It was complicated to reach an agreement on Kodi side but I'm sure we can do the same here. Access to sources via a flag that users can configure should be possible.

we have both of those commits in MrMC, it was done in 2013

[Tolriq]

You may have those commits but there's a filter before that makes them useless

if fullpath is null, end of story... we cant allow it blindly

You currently do So maybe I should have not said anything and leave the hole :p Not the kind of guy I'am

Anyway so it seems the opening of sources is no go despite Davilla (He have whole story and many discussions over the years on PR and Kodi security ) first answer here and reason I added support as I usually do not add things that half works.

All your calls please just take time to update here whether you close the working situation on Android, or support allowSharing option so I know what to tell to users when they ask.