1. No user installed addons are supported, python or otherwise.
2. No, they really are not supported.
3. They are not coming back
4. Read from 1. again

Any mention of illegal streaming sites, addons or any pirated material will not be tolerated. This is not democracy and any offenders will be banned and posts deleted immediately without warning.

Other than that, we hope you enjoy MrMC so far and we welcome any input and feedback you might have.

Team MrMC.

EDL file skip / comskip broken on >= 3.0

Report any issues you might have in here
morbo1980
Posts: 9
Joined: 29 Jun 2017, 06:05

EDL file skip / comskip broken on >= 3.0

Post by morbo1980 » 29 Jun 2017, 06:38

Hi,

Ever since the update to version 3 of MrMC I've had a problem that EDL file handling (generated from comskip) doesn't work correctly. This is on Apple TV but I've confirmed that it is also an issue on iOS. The problem still exists on 3.0.7 on Apple TV.

What happens is as follows...

* Video (tv recording) is playing
* MrMC will show on screen that it's about to skip ahead (over a commercial break)
* The skip will appear to happen, but now MrMC will sit as if paused on the first frame after the skip
* If you don't do anything eventually it will resume playing from the point after the skip (after the time has elapsed that was skipped)
* The wait can be bypassed by doing a big skip twice (ie: hit up on the remote twice). The video will resume playing from the end of the skip.

This issue was initially in Kodi 17 and fixed in 18 dev and then backported to 17.1 according to several posts on the Kodi forums. The specific pull requests that are supposed to implement the fix are as follows...
https://github.com/xbmc/xbmc/pull/11646
https://github.com/xbmc/xbmc/pull/11714

Would it be possible to port this fix into MrMC?

Thanks,
Ben

User avatar
amet
Team MrMC
Posts: 1507
Joined: 26 Oct 2015, 16:59

Re: EDL file skip / comskip broken on >= 3.0

Post by amet » 29 Jun 2017, 07:43

Hi,

we will look into it, it might not be as simple as using Kodi commits as our internal player engine is a bit different then theirs.... I'll let @davilla answer this, but no reason we can't look into fixing it.

Are you playing this file via PVR backend? does the same issue happen if you play it from a folder? if so, could you share the recording and EDL file with us? contact us on support@mrmc.tv if you can, then we can reproduce and fix.

thanks for letting us know there is an issue :)

amet

User avatar
davilla
Team MrMC
Posts: 2346
Joined: 26 Oct 2015, 17:01

Re: EDL file skip / comskip broken on >= 3.0

Post by davilla » 29 Jun 2017, 13:21

These can be back-ported. I was waiting to see if anyone complained as I don't use EDL. Best get into testflight where you can test some blind commits.

User avatar
davilla
Team MrMC
Posts: 2346
Joined: 26 Oct 2015, 17:01

Re: EDL file skip / comskip broken on >= 3.0

Post by davilla » 05 Jul 2017, 17:39

grr, those patches are messy and touch too much to do blind.

To fix this, we need the recording and EDL files.

morbo1980
Posts: 9
Joined: 29 Jun 2017, 06:05

Re: EDL file skip / comskip broken on >= 3.0

Post by morbo1980 » 11 Jul 2017, 08:58

Sorry I haven't been on earlier to follow up on this. I'm currently (slowly) uploading a video to OneDrive that shows the problem. Here's the link for when it finishes https://1drv.ms/f/s!Ar6IzANKIbrXjlnOs09uV4MXk1N0

Playing the file from the beginning will do a 2:15 jump that works correctly to start the video from after the initial ad break. The next ad break is soon after the 12 minute mark and that auto skip will show the problem.

User avatar
davilla
Team MrMC
Posts: 2346
Joined: 26 Oct 2015, 17:01

Re: EDL file skip / comskip broken on >= 3.0

Post by davilla » 11 Jul 2017, 17:02

morbo1980 wrote:
11 Jul 2017, 08:58
Sorry I haven't been on earlier to follow up on this. I'm currently (slowly) uploading a video to OneDrive that shows the problem. Here's the link for when it finishes https://1drv.ms/f/s!Ar6IzANKIbrXjlnOs09uV4MXk1N0

Playing the file from the beginning will do a 2:15 jump that works correctly to start the video from after the initial ad break. The next ad break is soon after the 12 minute mark and that auto skip will show the problem.
Let me know here when video is uploaded, thx.

morbo1980
Posts: 9
Joined: 29 Jun 2017, 06:05

Re: EDL file skip / comskip broken on >= 3.0

Post by morbo1980 » 12 Jul 2017, 00:21

The video has finished uploading.

Thanks.

User avatar
davilla
Team MrMC
Posts: 2346
Joined: 26 Oct 2015, 17:01

Re: EDL file skip / comskip broken on >= 3.0

Post by davilla » 12 Jul 2017, 01:45

morbo1980 wrote:
12 Jul 2017, 00:21
The video has finished uploading.

Thanks.
ok, will pull it down when I get back on a fast net tomorrow. Will reply when I have it.

User avatar
davilla
Team MrMC
Posts: 2346
Joined: 26 Oct 2015, 17:01

Re: EDL file skip / comskip broken on >= 3.0

Post by davilla » 12 Jul 2017, 20:57

Got it, issue reproduced. Possible fixed it but I have to do more extensive testing as this touches critical areas in the player code.

User avatar
davilla
Team MrMC
Posts: 2346
Joined: 26 Oct 2015, 17:01

Re: EDL file skip / comskip broken on >= 3.0

Post by davilla » 13 Jul 2017, 13:06

3.0.9 (170713.340)
fix 206 HTTP we are getting from RSS feeds
fix possible crash when checking CheckLibLoadedAndLoad()
fix crashes in glrKillClient when we try to render while in background on iOS/tvOS
fix EDL lists
regression - bring up channel list on LiveTV on Select(hold)

fix is in testflight if you want to give it a try.

viewtopic.php?f=10&t=1253

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest