1. No user installed addons are supported, python or otherwise.
2. No, they really are not supported.
3. They are not coming back
4. Read from 1. again

Any mention of illegal streaming sites, addons or any pirated material will not be tolerated. This is not democracy and any offenders will be banned and posts deleted immediately without warning.

Other than that, we hope you enjoy MrMC so far and we welcome any input and feedback you might have.

Team MrMC.

Forced ASS subtitles not showing  [SOLVED]

Any issues that are tvOS specific
User avatar
timstephens24
Posts: 630
Joined: 09 Dec 2015, 22:43

Re: Forced ASS subtitles not showing

Post by timstephens24 » 02 Mar 2018, 19:09

timstephens24 wrote:
02 Mar 2018, 18:18
Ok I'll try when the power comes back. Stupid wind.
Well I lied, the power came back and my Synology is dead (clock flaw issue on Atom C2XXX CPU's). It'll be about a week/week and a half until I get the replacement.

User avatar
amet
Team MrMC
Posts: 2040
Joined: 26 Oct 2015, 16:59

Re: Forced ASS subtitles not showing

Post by amet » 02 Mar 2018, 19:35

ouch, sorry to hear that :(

User avatar
timstephens24
Posts: 630
Joined: 09 Dec 2015, 22:43

Re: Forced ASS subtitles not showing

Post by timstephens24 » 02 Mar 2018, 22:57

I'm impatient so I recreated my script on my Mac and added the most recent episode. I ran these tests with the subtitle setting set like this: "Video -> Subtitles -> Preferred subtitle language -> Forced only" and "Settings -> Appprearance -> International -> Language -> English"

Video -> Playback -> Preferred audio language -> English = No subtitles
Video -> Playback -> Preferred audio language -> English (US) = No subtitles
Video -> Playback -> Preferred audio language -> Original stream's language = No subtitles
Video -> Playback -> Preferred audio language -> User interface language = No subtitles
Video -> Playback -> Preferred audio language -> Japanese = No subtitles

Looking at the code... what if this:

Code: Select all

if (onlyforced)
{
  if ((ss.flags & CDemuxStream::FLAG_FORCED) && g_LangCodeExpander.CompareISO639Codes(ss.language, audiolang))
    return false;
  else
    return true;
}
    
Was this:

Code: Select all

if (onlyforced)
{
  if (ss.flags & CDemuxStream::FLAG_FORCED)
    return false;
  else
    return true;
}

User avatar
amet
Team MrMC
Posts: 2040
Joined: 26 Oct 2015, 16:59

Re: Forced ASS subtitles not showing

Post by amet » 03 Mar 2018, 03:57

I think that might be possible, forced subtitles should be forced... but I think the idea was that it forces the preferred audio language subtitle. If there was Armenian forced subtitle track as well as English it would be enabled before English.

User avatar
timstephens24
Posts: 630
Joined: 09 Dec 2015, 22:43

Re: Forced ASS subtitles not showing

Post by timstephens24 » 03 Mar 2018, 11:03

I just did some Googling about that and I think if there's more than one forced track, then only one of those should also have the default flag, and then that one would be displayed. There shouldn't be two subtitles with both forced and default set, only one.

User avatar
timstephens24
Posts: 630
Joined: 09 Dec 2015, 22:43

Re: Forced ASS subtitles not showing

Post by timstephens24 » 19 Mar 2018, 00:49

Most recent TestFlight they don't work with native Plex until I select the subtitle. With the Plex addon they playback with the subtitles enabled.

User avatar
timstephens24
Posts: 630
Joined: 09 Dec 2015, 22:43

Re: Forced ASS subtitles not showing

Post by timstephens24 » 24 May 2018, 16:24

Still the same issue in the most recent TestFlight. Playback won't load the subtitles. When using the Plex addon they're displayed properly.

User avatar
timstephens24
Posts: 630
Joined: 09 Dec 2015, 22:43

Re: Forced ASS subtitles not showing

Post by timstephens24 » 08 Jun 2018, 11:07

Still the same issue, but now it won't even display them when I choose them in the drop-down in the latest TestFlight. Using the 'other player' still just for these.

User avatar
amet
Team MrMC
Posts: 2040
Joined: 26 Oct 2015, 16:59

Re: Forced ASS subtitles not showing

Post by amet » 08 Jun 2018, 19:15

timstephens24 wrote:
08 Jun 2018, 11:07
Still the same issue, but now it won't even display them when I choose them in the drop-down in the latest TestFlight. Using the 'other player' still just for these.
could you make us a folder with a video/subtitle file that doesnt work please and upload somewhere? hit us on support@ mrmc tv if thats possible.

I have found an issue with some ASS subs not displaying correctly and that was fixed, was hoping that was the same issue you had

User avatar
timstephens24
Posts: 630
Joined: 09 Dec 2015, 22:43

Re: Forced ASS subtitles not showing

Post by timstephens24 » 08 Jun 2018, 19:49

I just uploaded the latest one I did and sent it to support@mrmc.tv.

Post Reply

Who is online

Users browsing this forum: Bing [Bot] and 5 guests